search

mercurius-js / mercurius-upload

graphql-upload implementation plugin for Fastify & mercurius
https://mercurius.dev/
MIT License
27 stars 10 forks source link

chore: rollback `fastify` to v3 #10

Closed SimenB closed 2 years ago

SimenB commented 2 years ago

By using v4, type declarations that only exist there gets pulled in, causing errors in fastify v3.

https://www.runpkg.com/?mercurius-upload@5.0.0/dist/index.d.ts#12

PabloSzx commented 2 years ago

We path is to update to v4, not to support v3, I'm sorry

SimenB commented 2 years ago

https://github.com/mercurius-js/mercurius-upload/blob/2f8d85ec6db00742ac803c4bd67537efe4af8ecb/index.ts#L36

And the code in this repo would remain identical, so supporting both v3 and v4 shouldn't be a burden

SimenB commented 2 years ago

11 makes this impossible