search

mercurius-js / mercurius-upload

graphql-upload implementation plugin for Fastify & mercurius
https://mercurius.dev/
MIT License
29 stars 12 forks source link

fix: rename `isMultipart` to `mercuriusUploadMultipart` #4

Closed SimenB closed 2 years ago

SimenB commented 2 years ago

The declaration of isMultipart in this module conflicts with the one in fastify-multipart. The one there seems more generally useful, so I suggest renaming here.

fastify encapsulation makes sure this isn't an issue at runtime, but TS is unhappy.

image

(issues aren't enabled, otherwise I'd use that - not sure about just changing the name).

PabloSzx commented 2 years ago

(issues aren't enabled, otherwise I'd use that - not sure about just changing the name).

interesting, I can't enable issues in this repo for some reason :confused:

PabloSzx commented 2 years ago

thank you :smile: