search

mercurius-js / mercurius-upload

graphql-upload implementation plugin for Fastify & mercurius
https://mercurius.dev/
MIT License
27 stars 10 forks source link

feat: update `graphql-upload` #5

Closed SimenB closed 2 years ago

SimenB commented 2 years ago

To pull in an updated busboy which avoids a vulnerable dicer, see https://github.com/jaydenseric/graphql-upload/releases/tag/v15.0.0

Both updates minimum graphql and node, so this is a breaking change

SimenB commented 2 years ago

Ugh, the changed exports are absolutely horrendous to deal with (at least to get TS to work: https://github.com/jaydenseric/graphql-upload/issues/282)...

SimenB commented 2 years ago

seems to work now, but the other 2 PRs should land first to make the diff here readable

PabloSzx commented 2 years ago

https://github.com/mercurius-js/mercurius-upload/pull/8 it seems to be working here, I basically rebased, fixed conflict and updated lockfile

PabloSzx commented 2 years ago

8 it seems to be working here, I basically rebased, fixed conflict and updated lockfile

feel free to do the same changes 👍

SimenB commented 2 years ago

either pnpm or GH seems to have issues atm, but I rebased this now 👍

PabloSzx commented 2 years ago

it was some rare gh actions issues, now it's working

SimenB commented 2 years ago

it was some rare gh actions issues, now it's working

Yeah, https://www.githubstatus.com/incidents/6r4sms3hcj3x