GraphQL Subscriptions onConnect access context and socket

[teovillanueva]

Hi, I’m currently trying to implement authentication for my subscriptions and i found out the onConnect method is very limited. I can't access the context to set some properties neither the socket. I can open a PR, let me know if this makes sense ;)

[teovillanueva]

Looking at this test,

test('subscription connection extends context with onConnect return value', async (t) => {
  t.plan(3)

  const context = {
    a: 1
  }

  const sc = new SubscriptionConnection({
    on () {},
    close () {},
    send (message) {
      t.equal(JSON.stringify({ type: 'connection_ack' }), message)
    }
  }, {
    context,
    onConnect: function () {
      return { data: true }
    }
  })

  await sc.handleConnectionInit({})
  t.is(sc.context.data, true)
  t.is(sc.context.a, 1)
})

whatever is returned in the onConnect is added to the context right?

[PabloSzx]

whatever is returned in the onConnect is added to the context right?

yes

[teovillanueva]

Cool!

[SkeLLLa]

I also wanted to modify onConnect behavior, since now it's just uses shallow merge which means that some nested props will be overridden.

So what I've found so far that this argument in onConnect function points to SubscriptionConnection instance which has context property. Is this behavior considered as valid? If so, then I guess it needs to be documented and types for SubscriptionConnection are missing.

Or maybe it will be good if we allow option to choose shallow/deep merge?

[pasha-vuiko]

any updates on this?