Incorrect overload types of hooks

[npdev453]

That code:

 app.graphql.addHook('preExecution', (schema, document, context) => {});

make that error:

No overload matches this call.
  The last overload gave the following error.
    Argument of type '"preExecution"' is not assignable to parameter of type '"onGatewayReplaceSchema"'.ts(2769)
index.d.ts(362, 3): The last overload is declared here.

[npdev453]

Ah, its because I call it without async keyword. but is it really nessesacy with synchronius logic? (also its conflict with eslint no async without awaits rule)

app.graphql.addHook('preExecution',  async (schema, document, context) => {});

Seems like in type should be something ()=>Promise<T> | T

[mcollina]

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

It's ok to update the types to ()=>Promise<T> | T.

[raulsoledispa]

@mcollina, I'd like to send a PR to address this issue. Can you assign it to me?

[mcollina]

go for it!