search

mercurius-js / mercurius

Implement GraphQL servers and gateways with Fastify
https://mercurius.dev/
MIT License
2.34k stars 234 forks source link

fix: as gateway resolver key should handle digits (#880) #881

Closed marcobeca closed 1 year ago

marcobeca commented 1 year ago

Fixes #880

mcollina commented 1 year ago

@jonnydgreen the replacement was added by you in https://github.com/mercurius-js/mercurius/pull/754, however the tests are not failing.

jonnydgreen commented 1 year ago

@jonnydgreen the replacement was added by you in https://github.com/mercurius-js/mercurius/pull/754, however the tests are not failing.

Interesting, I'll take a look this evening!

jonnydgreen commented 1 year ago

Apologies, something came up so I wasn't able to have a look last night - I've blocked some time over the weekend so I'll have a look then if that's okay!

jonnydgreen commented 1 year ago

@mcollina am I missing something here, it seems that the replacement (assuming you're talking about the _IDX_ replacement) wasn't added in the PR you linked? I only added the type suffix in #754 , which is not changed in this PR?

Screenshot 2022-10-01 at 17 25 49

However, either way, I would expect the tests to fail, yep

mcollina commented 1 year ago

Ah,yeah! I made a mistake. I'll keep looking with git blame and see where it come from!

mcollina commented 1 year ago

The _IDX_ replacement was added in https://github.com/mercurius-js/mercurius/pull/130. I think it's safe to land this change.