mercurius-js / mercurius

Implement GraphQL servers and gateways with Fastify
https://mercurius.dev/
MIT License
2.34k stars 234 forks source link

feat: export SubscriptionClient class #920

Closed codeflyer closed 1 year ago

codeflyer commented 1 year ago

in this PR:

mcollina commented 1 year ago

I would rather export it in a separate module instead. Wdyt?

codeflyer commented 1 year ago

I would rather export it in a separate module instead. Wdyt?

You mean export just the Subscription Client? Or all the subscription feature?

In the first case we can build a module like @mercurius/subscription-tools and use them directly in the mercurius part that manage the subscription.

I wont extract instead the feature completely.

Wdyt?

mcollina commented 1 year ago

I would extract only the SubscriptionClient.

marco-ippolito commented 1 year ago

I would extract only the SubscriptionClient.

this is being done here https://github.com/mercurius-js/mercurius-subscription-client/pull/3

marco-ippolito commented 1 year ago

@mcollina @codeflyer we can close this has has been resolved by https://github.com/mercurius-js/mercurius/pull/938