search

mercurius-js / mercurius

Implement GraphQL servers and gateways with Fastify
https://mercurius.dev/
MIT License
2.33k stars 234 forks source link

Update to @fastify/websocket v8 #987

Closed mcollina closed 1 year ago

mcollina commented 1 year ago

Updates to @fastify/websocket v8 to address a leak and crash in certain condition. This requires a minimum version of Fastify of v4.16.0 (just released), hence the major update.

mcollina commented 1 year ago

cc @simoneb @codeflyer @marco-ippolito @jonnydgreen wdyt?

This fixes a horrible crash in Platformatic, so I'm keen on shipping this sooner rather than later.

simoneb commented 1 year ago

I'm afraid I'm missing some context but it looks like this is part of a group of upgrades to various packages that need to go together (I see the major in fastify-ws, a minor followed by various patches in fastify, fastify-json-stringify and compiler, ...). There's an overarching plan I'm missing, but I guess we're good as I wouldn't be in any better position than you are to validate this change.

mcollina commented 1 year ago

There is no grand plan, just this bug to be fixed https://github.com/fastify/fastify-websocket/issues/249. That required a new hook in Fastify and and a semver-major change jn fastify-websocket.

The change in fast-json-stringify was 100% unrelated as well as all the problems in v4.16.3.