search

mercurius-js / validation

Adds configurable validation support to Mercurius.
MIT License
29 stars 6 forks source link

Upgrade Fastify to v4 #53

Closed jonnydgreen closed 2 years ago

jonnydgreen commented 2 years ago

@mcollina was gonna ship this as a new major change, what do you reckon about bundling https://github.com/mercurius-js/validation/pull/52 with it as well? I can see the argument for patch change for https://github.com/mercurius-js/validation/pull/52 but I'm thinking that even if it is a fix, when changing the default status code we could also be changing existing functionality that people rely on - WDYT?

mcollina commented 2 years ago

yeah bundle both together in a semver-major change.