fix: user-routes-redirect - Githubissues

mercurjs / mercur-api-starter

5 stars 9 forks source link

fix: user-routes-redirect #19

Closed tomaszburas closed 3 months ago

tomaszburas commented 4 months ago

Fix Redirect Issue for Routes /admin/users/password-token and /admin/users/reset-password

Description: This pull request addresses a routing issue in the Mercur.js project, which is based on the Medusa.js framework. The problem involved incorrect redirects for the routes /admin/users/password-token and /admin/users/reset-password, which were erroneously directed to the user update route /admin/users/[user_id].

Problem:

The routes /admin/users/password-token and /admin/users/reset-password were being redirected to the user update route /admin/users/[user_id].
It was not possible to override this behavior using middleware, making it difficult to implement password reset and token generation functionalities.

Solution:

Modified the routing logic so that the routes /admin/users/password-token and /admin/users/reset-password are no longer redirected to the user update route.
Added appropriate implementations to handle these routes and prevent incorrect redirection.

Testing:

Verified that the route /admin/users/[user_id] still works correctly and allows for user data updates.

Additional Information:

This pull request does not introduce any changes to existing user functionalities beyond improving the handling of routes related to password reset.
Please review the changes and approve the pull request to ensure the issue is resolved promptly.

Links to Related Issues: github.com/mercurjs/mercur/issues/13

NicolasGorga commented 3 months ago

Hello, will this be merged?