Add partial day selection

mercurymedia / elm-datetime-picker

Single and duration datetime picker components written in Elm 0.19

https://package.elm-lang.org/packages/mercurymedia/elm-datetime-picker/latest/

MIT License

16 stars 6 forks source link

Add partial day selection #16

Closed jmpressman closed 4 years ago

jmpressman commented 4 years ago

Changes

Closes: #9

Adds ability to select a day on the Calendar but only allow certain times within the day to be selected.
- i.e. I can select today, Thursday 19.12.19, on the Calendar, but I won't be able to select any times prior to the current time of day.

New basic picker gif: updated-basic-picker-2

jmpressman commented 4 years ago

Found some bugs that should be solved

Minutes are still selectable when no valid time exist for a day (which isn't the case for hours and shouldn't be for minutes either)

A date gets selected even when no time is selectable

@mschindlerMM Can you provide steps to replicate 1 & 2?

The selected time seems 1 hour off (wasn't the chase in my last review, I would say)

This will be addressed when I handle time zones in the relevant issue.

mschindlerMM commented 4 years ago

@mschindlerMM Can you provide steps to replicate 1 & 2?

I changed the endHour of { startHour = todayParts.hour, startMinute = todayParts.minute, endHour = 16, endMinute = 30 } in the basic example datepicker-settings to something in the past (i.e. { ..., endHour = 2, endMinute = 30 }

This will be addressed when I handle time zones in the relevant issue.

I don't think this is a timezone issue, since everything in the datepicker, as well as in the example, is in UTC. Also I don't think this has been an issue before.