search

merddyin / ADDeploy

Used to deploy components to support an ESAE forest and RBAC model via native control.
MIT License
2 stars 0 forks source link

Tool is missing a "whatIf" feature #15

Open PatrickOnGit opened 1 year ago

PatrickOnGit commented 1 year ago

The tool should have a feature to show report what it would change. It can then be used to compare existing with desired (in SQLite DB stored) configuration.

merddyin commented 1 year ago

Unfortunately this is another item that has, at least partially, been addressed in the updated code base. I have implemented whatif functionality in any of the fully refactored functions, but it's still on the 'to-do' list for most of the cmdlets unfortunately. I would also note that, while I say that the code base is as yet uncommitted, that is only partially accurate. The updated code base is in a private repository on Azure DevOps...I just have to go through it with a fine-tooth comb before doing a commit to the public repo here. I use this module for customer engagements, and sometimes I have to make ad-hoc fixes to address specific items that are unique to that environment. I should not have any such items in my main branch, but I still have to have time to do a code review and make sure first. As you have no doubt noticed, there are a lot of lines of code to review.

PatrickOnGit commented 1 year ago

I'm happy to assist. As you may have noticed, I have to "maintain" your code at a customer of mine. So if you could provide some "non-public" code I may be able to update the code at my customer and provide feedback and hopefully some improvements back to you.

merddyin commented 1 year ago

Happy to hear that someone else is getting some use out of this module, and thrilled that you happened across my tool. First, I have uploaded a current version copy of the module to the Dev branch on this repo. There are several key items that need to be fixed before I can do a PR, but it is functional enough for use with a few minor caveats, all of which are outlined under docs\ChangeLog. You will see that at least some of the cmdlets do now implement WhatIf, though not all do yet. I still have a bunch of refactoring to do, but time is always a problem.

As for getting further insight into how things are put together, until I have time to write up all the documentation, you are welcome to reach out to me directly via the email link on my website (https://mer-bach.com). We can also, of course, continue to converse here, but it may be more useful to you to be able to compile all of your questions and have a more verbose discussion. Leaving this open.