merddyin / ADDeploy

Used to deploy components to support an ESAE forest and RBAC model via native control.
MIT License
2 stars 0 forks source link

Credentials provided are only used by DSC commands #18

Open PatrickOnGit opened 1 year ago

PatrickOnGit commented 1 year ago

Only DCS commands are using provided credentials and are writing them in clear into the MOF files. Everything else is running in current users context.

This is confusing. You may name the parameter "DSCCredentials" or use the Credential parameter to run the full script in the context of the provided credentials.

merddyin commented 1 year ago

I apologize, but I'm somewhat confused. None of the cmdlets for this module use DSC, and none presently accept credentials in either the Master or Dev branch. None of the plugins do either. Are you sure you put this on the correct repo?

PatrickOnGit commented 1 year ago

As it looks like, I got hold of a slightly different version and didn't compare it well enough. The version I was handed over and had to make working does use DSC to build the OU structure. But almost all other features are using the same code as published on GitHub. Sorry for the confusion. So I guess you can close this issue.