search

merdok / homebridge-webos-tv

Homebridge plugin for LG webOS TVs
MIT License
664 stars 89 forks source link

Volume up/down as trigger from remote #358

Closed rooi closed 3 years ago

rooi commented 3 years ago

Hi Merdok!

I've just update to the new version 2.x.x of your plugin. Great changes! Is it me, or is the volume up/down trigger not working any longer? https://github.com/merdok/homebridge-webos-tv/pull/147

When I press up/down on the remote, I can see the following message in homebridge debug: [TV] Audio status changed. Current volume: 7, Muted: No

Still my automations don't get triggered.

I check to code and noticed the prepareTvSpeakerService() and the following lines: this.logDebug('Volume change over the remote control (VolumeSelector), pressed: %s', state === Characteristic.VolumeSelector.DECREMENT ? 'Down' : 'Up');

This debug message is not show. Could this be related to the missing up/down tigger or am I doing something wrong?

Thanks!

Roy

merdok commented 3 years ago

Oh, you are right! This somehow got lost during the update. Will have a look at it and try to add it back in the next update.

rooi commented 3 years ago

Thx!

merdok commented 3 years ago

Should be fixed in version 2.1.2

rooi commented 3 years ago

That was fast, thanks! Work great!