search

merdok / homebridge-webos-tv

Homebridge plugin for LG webOS TVs
MIT License
656 stars 88 forks source link

Update LgTvController.js #469

Closed VladLikov closed 1 year ago

merdok commented 1 year ago

Hello, why do you provide this pull request? Did the "brightness" changed to "oled_light" on your tv?

VladLikov commented 1 year ago

Hello,

I have an LG CX TV, it's an Oled TV and "brightness" settings from your code doesn't work properly.

merdok commented 1 year ago

Yeah, but how about other TVs (especially non OLED TVs) which does not have "oled_light"? Does "brightness" throw an error on your TV? Cannot we leave "brightness" in and add "oled_light" additionally?

VladLikov commented 1 year ago

Yes, of course we need to leave "brightness" in. And will be great if you add "oled_light" additionally. Thank you.

merdok commented 1 year ago

Can you make the necessary change, please? We could then merge your pull request.

VladLikov commented 1 year ago

Unfortunately I don't have much experience in JS. If you can do it by yourself it would be great.

merdok commented 1 year ago

From where do you have the oled_light settings key? Unfortunately it does not exists...