merdok / homebridge-webos-tv

Homebridge plugin for LG webOS TVs
MIT License
646 stars 88 forks source link

Feature Request - Make Volume Control Service name editable #533

Open Depicus opened 1 month ago

Depicus commented 1 month ago

Is it possible to set the name of the Volume Control Service - I call it Telly Noise by setting it's name in HomeKit but every time I reboot Homebridge it reverts and I sound like a lunatic shouting at the TV to turn the Telly Noise off when it's now back to LG Volume Control.

Great plugin thank you.

merdok commented 1 month ago

This is a known issue that after a reboot the names of the accessories revert back to the auto generated ones. I have it on my scope to provide a fix but since it will probably require some extensive code changes I did not find the time to do it yet... hopefully I can tackle it soon!

ltdowney commented 1 month ago

I came here to request the volume service name be configurable as well and saw this, so +1 if you do get time at some point. šŸ‘

I see that you set it as <accessory_name> + ā€˜ Volumeā€™. The problem is that my accessory is named ā€œLiving Room TVā€, but Siri gets confused when I ask her to adjust the ā€œLiving Room TV Volumeā€ ā€“ probably because the AI hears ā€œLiving Room TVā€ and expects it to be an attribute on the TV itself ā€“ so I have to ask in a contorted way, like ā€œadjust the Living Room level to 10%ā€. Fortunately I donā€™t have any dimmer-light accessories in my home, otherwise that wouldnā€™t work as sheā€™d adjust all of them.

Regardless though, thanks for the great plugin, itā€™s enabled me to do a lot of cool automations that arenā€™t possible with LGā€™s own implementation!

merdok commented 1 month ago

A very important note is that Siri officially cannot control the volume of any devices, so if there is the word "Volume" in your command then it might misinterpret it. You have to control the volume as you would control the light bulb or fan which is used to emulate it, hence saying "Set living room level to 20%" is the correct and only way to do that.

ltdowney commented 6 days ago

Sorry for the month-late follow-up / ping, just noticed your reply in my notifications. Donā€™t mean to belabor the point, just a couple more thoughts and then Iā€™ll leave you in peace to [de-]prioritize as you see fit. šŸ˜…

A very important note is that Siri officially cannot control the volume of any devices, so if there is the word "Volume" in your command then it might misinterpret it. You have to control the volume as you would control the light bulb or fan which is used to emulate it, hence saying "Set living room level to 20%" is the correct and only way to do that.

For sure, thatā€™s the most natural term I could think of for now, and it does work. I think the strongest argument would probably be to work around collision with actual dimmer lights in the same room. Admittedly I donā€™t have that problem, but itā€™d probably be a showstopper for that feature to anyone who does.

In terms of what I might actually do with a configurable service name, I can imagine some that might be useful along the lines of ā€œLiving Room Speakersā€ or ā€œLiving Room Outputā€ ā€“ Siri limitations permittingā€¦ Letā€™s hope Apple Intelligence can make her more capable, in any case! šŸ˜†šŸ¤ž