Fixing missing/broken links in setup instructions

merely-useful / py-rse

Research Software Engineering with Python course material

http://third-bit.com/py-rse/

Other

246 stars 63 forks source link

Fixing missing/broken links in setup instructions #498

Closed DamienIrving closed 3 years ago

DamienIrving commented 3 years ago

Ready for review.

DamienIrving commented 3 years ago

Come to think of it, rather than linking to https://github.com/merely-useful/py-rse/raw/book/data/zipf.zip for people to download the data files, should we put them up on Figshare (or similar site)? That way the dataset has a permanent location, rather than a location that can disappear if we make a tiny change to the name of our repo or even just the book branch. We can follow our own advice in the provenance chapter to document the data on Figshare.

lwjohnst86 commented 3 years ago

Great question @DamienIrving... I'm definitely in favour of submitting to figshare/zenodo. As you said, it would make things much easier for those using the book.

gvwilson commented 3 years ago

:+1: to Figshare/Zenodo - practice what we preach.

DamienIrving commented 3 years ago

Ok. I've posted the dataset to Figshare and updated the Setting Up appendix accordingly. https://doi.org/10.6084/m9.figshare.13040516

gvwilson commented 3 years ago

You're a good person - is this one ready to merge?

DamienIrving commented 3 years ago

Yep, ready to merge.