Change target to reflect a previous makefile change

merely-useful / py-rse

Research Software Engineering with Python course material

http://third-bit.com/py-rse/

Other

246 stars 63 forks source link

Change target to reflect a previous makefile change #571

Closed joelostblom closed 3 years ago

joelostblom commented 3 years ago

I believe this is the reason why travis is failing, not sure how important it is for us but let's see if this fixes it https://github.com/merely-useful/py-rse/commit/41398d6c42fa77360276a2c4d69e5c26ff2fcd07#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L58-L59

gvwilson commented 3 years ago

Looks good to me - @lwjohnst86 can you please check as well?

DamienIrving commented 3 years ago

The checks failed on this PR (https://travis-ci.org/github/merely-useful/py-rse/builds/748866655), does that mean it isn't fixed?

joelostblom commented 3 years ago

The previous error is fixed, we're running into a new one now. Travis' pandoc seem to be complaining that --metadata-file is not a valid option but it certainly is (unless that pandoc version is ancient maybe?). The pandoc command is autogenerated by our RMarkdown command in the makefile, not sure if that matters. I could not find anything on the pandoc issue tracker so suspecting that the error lies elsewhere and this is a side effect.

lwjohnst86 commented 3 years ago

Sorry guys, thought I got rid of the travis file. We're using GitHub Actions to build the website, not Travis. Closing