search

merely-useful / py-rse

Research Software Engineering with Python course material
http://third-bit.com/py-rse/
Other
246 stars 63 forks source link

Fix image size problems #591

Closed lwjohnst86 closed 3 years ago

lwjohnst86 commented 3 years ago

Figures 2.2, 2.5, 3.1, 3.2, and E.1 had their pdf images with extra space around the edges (from the export from draw.io). Fixed it so only the image was exported.

gvwilson commented 3 years ago

Just rebuilt - the changes all look good to me, but I think the screenshot of Nano and the structure of a man page will both be clearer if they are dark-on-white instead of white-on-dark - can you please recapture and stuff 'em into this PR and I'll re-review?

lwjohnst86 commented 3 years ago

Regarding, the dark on white, the man page has extra stuff added to it and also looks different from mine when I do man wc. @k8hertweck you did this image, do you mind switching the man background to dark on white?

k8hertweck commented 3 years ago

Yup, I can do this

gvwilson commented 3 years ago

Thanks - gi's a shout when it's in?

k8hertweck commented 3 years ago

@gvwilson @lwjohnst86 Added the man image; let me know if it needs to be tweaked (I didn't check in the rendered book).

gvwilson commented 3 years ago

Thanks very much - the only one that's still white-on-black is the first one (Fig 2.1, "The Bash shell"). Can someone please re-do that and then merge this? Everything builds fine for me with the new figs.

k8hertweck commented 3 years ago

I've got it.

k8hertweck commented 3 years ago

@gvwilson Done!