Closed ShaiberAlon closed 5 years ago
Both suggestions make sense.
For the (1), we need to make sure the parameter name change is reflected on any relevant web material.
For (2), would you like to do it or would you prefer me to do it? :)
Best,
I would prefer that you do t if you don't mind. Especially because #1061 makes me worry that there are more hidden issues with this module.
I see. I am looking at it now.
Can you try again after cf874b8673160fd9709087076e1db2d36da8dde3? :)
This still doesn't work.
I wanted to see whether closing was going to fix it :(
You should open an issue with the GitHub people :-)
Brilliant.
This must be closing this: a8a2f153da9d3a9f1fb3eac730e5878477a44fda
Nope...
If you want to easily reproduce my issue, then checkout the branch metapan-workflow
, and then run ./run_pangenomics_workflow_tests.sh
(in the anvio test folder).
I tried and couldn't reproduce this using the script ./run_pangenomics_workflow_tests.sh
. I assume it is somehow fixed :(
When using
--min-num-bins-gene-occurs
inanvi-get-sequences-for-hmm-hits
with external genomes then you get this message:They way I think it should work is:
--min-num-bins-gene-occurs
to--min-num-genomes-gene-occurs
(more compatible with the names--external-genomes
and--internal-genomes
--min-num-genomes-gene-occurs
is 2. Then anvi'o should be happy and give us the output sequences.@meren, what do you think?