search

merenlab / anvio

An analysis and visualization platform for 'omics data
http://merenlab.org/software/anvio
GNU General Public License v3.0
426 stars 145 forks source link

2043 bug support values can be misplaced in the interactive interface #2084

Closed metehaansever closed 7 months ago

metehaansever commented 1 year ago

Hey, I am finally fixed the bug. I was using the tree from the related paper: ((C,D)1,(A,(B,X)3)2,E)R; Can anyone else try it and confirm it works? I leave the pull request open until I complete the scenario of giving 2 branch support values.

FlorianTrigodet commented 1 year ago

The bootstrap values are now correctly placed, but a new one appeared: the 1 close to the root of the tree didn't exist before.

image

When the tree is rerooted using anvi'o, I get the following newick tree with a bootstrap value that shouldn't be there:

(X:0.5,(B:1,(A:1,((C:1,D:1)1:1,E:1)2:1)3:1)1:0.5);
                                           ^

It should look like this instead:

(X:0.5,(B:1,(A:1,((C:1,D:1)1:1,E:1)2:1)3:1):0.5);
metehaansever commented 1 year ago

Thank you, Florian! format=0 set default value to the branch support values. I'll fix that.

meren commented 1 year ago

Any progress on this? Is this issue anywhere close to being addressed?