merenlab / anvio

An analysis and visualization platform for 'omics data
http://merenlab.org/software/anvio
GNU General Public License v3.0
423 stars 144 forks source link

gene popover functionality #2134

Closed metehaansever closed 11 months ago

metehaansever commented 11 months ago

Since the length value was not returned from the meta.json file, I left it as static. I guess there is no Annotations value either. In addition, for missing values in some genes, for example, id: 28, we can return the values to none.

image

FlorianTrigodet commented 11 months ago

I'll add length in the json. I'm also working on adding DNA and AA sequences into the json. But that requires me learning more about anvi'o class etc.

metehaansever commented 11 months ago

I'll add length in the json. I'm also working on adding DNA and AA sequences into the json. But that requires me learning more about anvi'o class etc.

In that case, we can merge this branch after we finish the DNA and AA functionality.

meren commented 11 months ago

How come there is no annotation but there is an accession for the annotation? :)

FlorianTrigodet commented 11 months ago

Now they do! Annotations are called 'function' in the json

meren commented 11 months ago

@metehaansever, please make sure the popovers has a fixed width of 900px. The contents of the annotation column should wrap in each td.

FlorianTrigodet commented 11 months ago

DNA and AA sequence are available for each gene. They are accessible as DNA_sequence and AA_sequence in the gene part of the json. Now we can make a button to display these sequences :D

FlorianTrigodet commented 11 months ago

Oh, should I provide a fasta header like in inspect page?

metehaansever commented 11 months ago

Oh, should I provide a fasta header like in inspect page?

I guess, this is a good idea because they'll copy and paste somewhere else. But I guess I can handle that on the UI :)

FlorianTrigodet commented 11 months ago

Now there is a fasta header in the summary (called 'header' because I have a lot of imagination this morning). I also fix the DNA reporting part because if the gene is in rev direction, the sequence should be reverse complemented. Ready for the DNA and AA button :D

metehaansever commented 11 months ago

we replaced the popover top to the bottom. The reason was the Function's width. And I added AA/DNA buttons. image

meren commented 11 months ago

Some attention to detail please: can anyone answer why the borders for the inner div are not equally distant to the borders of the popover at all edges? No. No one can answer that. But they can make sure it is not the case :)

image

metehaansever commented 11 months ago

I hope, it's not the case anymore :+1: image

FlorianTrigodet commented 11 months ago

Shame on WHOEVER could have forgotten a print statement in the code ...

Looks nice to me with the latest changes. Ready for merge do you think?

meren commented 11 months ago

Yes! Thank you both :) Merge whenever, boss.

meren commented 11 months ago

(but please don't forget to update the documentation with some screenshots or whatever, so it is clear what we're generating)