Closed metehaansever closed 11 months ago
I'll add length in the json. I'm also working on adding DNA and AA sequences into the json. But that requires me learning more about anvi'o class etc.
I'll add length in the json. I'm also working on adding DNA and AA sequences into the json. But that requires me learning more about anvi'o class etc.
In that case, we can merge this branch after we finish the DNA and AA functionality.
How come there is no annotation but there is an accession for the annotation? :)
Now they do! Annotations are called 'function' in the json
@metehaansever, please make sure the popovers has a fixed width of 900px. The contents of the annotation column should wrap in each td
.
DNA and AA sequence are available for each gene.
They are accessible as DNA_sequence
and AA_sequence
in the gene part of the json.
Now we can make a button to display these sequences :D
Oh, should I provide a fasta header like in inspect page?
Oh, should I provide a fasta header like in inspect page?
I guess, this is a good idea because they'll copy and paste somewhere else. But I guess I can handle that on the UI :)
Now there is a fasta header in the summary (called 'header' because I have a lot of imagination this morning). I also fix the DNA reporting part because if the gene is in rev direction, the sequence should be reverse complemented. Ready for the DNA and AA button :D
we replaced the popover top to the bottom. The reason was the Function's width. And I added AA/DNA buttons.
Some attention to detail please: can anyone answer why the borders for the inner div are not equally distant to the borders of the popover at all edges? No. No one can answer that. But they can make sure it is not the case :)
I hope, it's not the case anymore :+1:
Shame on WHOEVER could have forgotten a print statement in the code ...
Looks nice to me with the latest changes. Ready for merge do you think?
Yes! Thank you both :) Merge whenever, boss.
(but please don't forget to update the documentation with some screenshots or whatever, so it is clear what we're generating)
Since the length value was not returned from the meta.json file, I left it as static. I guess there is no Annotations value either. In addition, for missing values in some genes, for example, id: 28, we can return the values to none.