search

merenlab / anvio

An analysis and visualization platform for 'omics data
http://merenlab.org/software/anvio
GNU General Public License v3.0
427 stars 145 forks source link

Should this be in dbops? #622

Closed ShaiberAlon closed 6 years ago

ShaiberAlon commented 6 years ago

@meren, right now this is only useful for MetagenomeCentricGeneClassifier, but maybe in the future some other class would access this. Should this function be transferred to dbops?

https://github.com/merenlab/anvio/blob/b803200d9f7689e95a456cb83f37a97f57ac8ec6/anvio/mcgclassifier.py#L420

meren commented 6 years ago

I looked into the design a bit. I think there are some ways to improve it, but after 45 minutes of coding and re-coding, I realized it is best if it stays where it is as a helper function.

Maybe we can at some point sit together and think about improving the design overall :)

Best,

ShaiberAlon commented 6 years ago

Sounds good!

On Tue, Oct 31, 2017 at 4:26 AM, A. Murat Eren notifications@github.com wrote:

Closed #622 https://github.com/merenlab/anvio/issues/622.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/merenlab/anvio/issues/622#event-1318344595, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ18dFlu7a7es1QIePRZuWuQfJc1iDrGks5sxufSgaJpZM4QLysk .