Closed ShaiberAlon closed 7 years ago
(Also notice that I suggest to change this: https://github.com/merenlab/anvio/blob/76c8f51a17c96a9530df67da384a24da032474a6/anvio/sequence.py#L198 to:
return numpy.array([True] * values.size)
So that the type of the object returned from this function is consistent (and always a numpy array and never a list)
This was a mistake on my part, and these changes look good to me, Alon. Thank you very much for catching it and providing a resolution.
@meren, if I understand this correctly then
median_absolute_deviation
will only be zero for a uniform distribution, but why did you choose to define the entire vector as all outliers? Were you maybe thinking of the case of all zeros? If so, then I suggest to change this line: https://github.com/merenlab/anvio/blob/76c8f51a17c96a9530df67da384a24da032474a6/anvio/sequence.py#L197To: