search

merge / skulls

pre-built coreboot images and documentation on how to flash them for Thinkpad Laptops
GNU General Public License v3.0
674 stars 65 forks source link

extra path in .sha256 #209

Closed bgklc closed 2 years ago

bgklc commented 2 years ago

sudo ./skulls.sh -b x230 does not find .sha256. If I remove skulls-1.0.3/ from x230_coreboot_seabios_45ce84113e_top.rom.sha256 it works smoothly.

yubiuser commented 2 years ago

I think the issue is here

https://github.com/merge/skulls/blob/6e2960423734da72d783d9019953c302040ca4b6/release.sh#L200-L211

sha256sum is invoked with the complete path of ${RELEASE_DIR} which then gets printed in the output. One solution would be to change into ${RELEASE_DIR} before and execute sha256sum only on $(basename "${RELEASE_IMAGE}") without the path.

henning-schild commented 2 years ago

Just wanted to report the same, the fix and the "blame" on recent release script changes.