merge
commented
6 years ago Thanks for reporting!
We might have a design flaw here and I'll fix this properly, but it'll take some time.
In the meantime: Could test xf86-input-tslib with the following change?:
diff --git a/src/tslib.c b/src/tslib.c
index fbbfe93..c547658 100644
--- a/src/tslib.c
+++ b/src/tslib.c
@@ -50,6 +50,7 @@
#include <sys/time.h>
#include <time.h>
#include <stdint.h>
+#include <fcntl.h>
#if defined (__FreeBSD__)
#include <dev/evdev/input.h>
@@ -463,8 +463,6 @@ static int xf86TslibInit(__attribute__ ((unused)) InputDriverPtr drv,
priv->slots = 0;
- pInfo->fd = ts_fd(priv->ts);
-
ts_error_fn = errfn;
/* process generic options */
@@ -475,6 +473,18 @@ static int xf86TslibInit(__attribute__ ((unused)) InputDriverPtr drv,
if (!priv->valuators)
return BadValue;
+ /* FIXME get the path from libts (ts_uinput needs that too) */
+ if (!s) {
+ xf86IDrvMsg(pInfo, X_ERROR, "Please provide path or Device");
+ return BadValue;
+ }
+
+ pInfo->fd = open(s, O_RDONLY);
+ if (pInfo->fd == -1) {
+ xf86IDrvMsg(pInfo, X_ERROR, "Couldn't open %s\n", s);
+ return BadValue;
+ }
+
if (ioctl(pInfo->fd, EVIOCGBIT(EV_ABS, sizeof(absbit)), absbit) < 0) {
xf86IDrvMsg(pInfo, X_ERROR, "ioctl EVIOCGBIT failed");
return BadValue;
and Set Option "Device" "/dev/input/eventX" in 80-tslib.conf ?
I know it's very ugly, but if this works for you, it would be great to know. I will fix it to work automatically. If I'm lazy, I'll require a new version of tslib to be installed, but even then, I'll document and write log messages that clear up confusion.
hvraven
dougg3
KwonTae-young
neilabdev
ar-speakerbus
Whenever I install this from the AUR on my Raspberry Pi (armv7h, not AArch64) it causes X to segfault. As soon as I uninstall it X goes back to working normally. Here's the log from X: xorg.log