search

mergeability / mergeable

🤖 All the missing GitHub automation 🙂 🙌
https://mergeable.us
GNU Affero General Public License v3.0
679 stars 120 forks source link

[question] should `skip_merge` also include `Merge pull request...` messages #721

Open hamza-shezad opened 1 year ago

hamza-shezad commented 1 year ago

when skip_merge is true, should commits with messages as following be skipped?

Merge pull request #111 from <repo>`
robinmayerhofer commented 1 year ago

Docs https://github.com/mergeability/mergeable/blob/590a40fa9ab9a5f3adbc11273687f043beb91aec/docs/validators/commit.rst#L10

and implementation https://github.com/mergeability/mergeable/blob/590a40fa9ab9a5f3adbc11273687f043beb91aec/lib/validators/commit.js#L69

      orderedCommits = orderedCommits.filter(commit => !commit.message.includes('Merge branch'))

diverge. Merge vs. Merge branch.

=> Fix the implementation?

hamza-shezad commented 1 year ago

yes. do you want me to open a PR?

robinmayerhofer commented 1 year ago

Yes, I would suggest that you open a PR and ping the maintainers!