search

mergesort / Recap

A What's New screen, and more
MIT License
161 stars 5 forks source link

An option for using a standard navigation bar title? #15

Open jverkoey opened 1 day ago

jverkoey commented 1 day ago

As-is the release notes title is rendered using a Text view in:

https://github.com/mergesort/Recap/blob/8ce1035505017e6d72a309c4b2c48ab6b79ecc20/Sources/Recap/Internal/ReleaseView.swift#L13-L19

This is good, in that it works for the general case of longer titles.

It would be nice (and note: this is definitely a "nice to have" feature request due to the expected relative complexity of the required changes to the code), if it was possible to use a standard .title modifier on the ReleaseView.swift and get the benefits of the UINavigationBar large title + scrolling behavior to make the UX feel more standard.

mergesort commented 13 hours ago

There are two reasons I would prefer not to make this change, but am open to feedback.

  1. There was an intentional change in the 1.1.0 release to move away from using a NavigationStack, which should allow me to add Mac support down the line.
  2. My goal is to mimic Apple's style of What's New Screen, treating it as a spec, while providing some flexibility for app-specific design patterns. From what I've seen (see: screenshot below of the Calendar What's New Screen with a large accessibility size enabled), Apple does not use a navigation bar to display the title for their What's New Screen. While I understand what you mean about standard UX, I would consider the way it is right now to be the standard UX in this case.

Does that seem reasonable @jverkoey?

jverkoey commented 12 hours ago

Ahh interesting. That's pretty good justification for tuning this then.

I wonder if we can improve the behavior then to use the frosted material effect when content scrolls behind the navigation bar then? I think the fact that it's a solid background is what makes it feel somewhat off (to me) right now.