search

mergestat / sqlq

sqlq is a SQL-backed, persistent, job queuing solution.
MIT License
2 stars 0 forks source link

fix(db): Closing connections after usage #43

Closed ramiroJCB closed 1 year ago

ramiroJCB commented 1 year ago

There is a significant difference of open connections without the explicit close function from 62 to 2 open connections with the test without changes screen_shot_2023-02-20_at_11 36 12_am_720 With the changes screen_shot_2023-02-20_at_11 40 23_am_720

codecov-commenter commented 1 year ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.20%. Comparing base (daece01) to head (282da86). Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
sqlq.go 60.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ========================================== - Coverage 62.64% 62.20% -0.45% ========================================== Files 11 11 Lines 589 590 +1 ========================================== - Hits 369 367 -2 - Misses 178 180 +2 - Partials 42 43 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.