search

mergestat / syncs

MergeStat container based syncs
MIT License
5 stars 10 forks source link

Run git syncs in transactions #36

Open khasinski opened 1 year ago

khasinski commented 1 year ago

This should prevent the cases in which the sync works only partially resulting in missing data or "blips" in specific repo data. Since there are no tests and I don't have a full local setup I'm not sure how to test it though 😅

patrickdevivo commented 1 year ago

Thanks for opening this @khasinski ! The -1 flag is supposed to execute all of these -c commands in a single transaction, but I like how this approach is much more explicit/clearer, so it makes sense to use it.

Do you mind removing the -1 flags? We're working on some instructions on how to validate these syncs locally, and a test suite as well 🙂

image

https://www.postgresql.org/docs/current/app-psql.html

khasinski commented 1 year ago

Yup, I've assumed -1 means machine-readable format for scripting like ls -1, boy was I wrong 😅

I've removed -1 from scripts and added --quiet for those missing it