meridianww / M4PLBase

0 stars 1 forks source link

Return Orders Not Populating Delivery Date Actual Field #494

Open nmfujimoto opened 3 years ago

nmfujimoto commented 3 years ago

For Return orders, when the "Return to (Customer)" gateway is added (EDI Status Code of "J1") to a job that order is considered "Completed" in the system and is ready for billing.

When the "Return to ..." (e.g. Return to AWC) gateway is added:

prashantaggarwal1999 commented 3 years ago

@nmfujimoto application is just updating the JobComplete when Gateway Code is like Return to. not populating the DeliveryDateActual, we need to update the DeliveryDateActual as well here:

        UPDATE job
        SET JobOriginDateTimePlanned = CASE WHEN (@gwyGatewayCode = 'Schedule' OR
                                                  @gwyGatewayCode = '3PL Arrival' OR 
                                                  @gwyGatewayTitle = 'Schedule Pick Up' OR 
                                                  @gwyGatewayTitle = 'Sched Pick Up') THEN Gateway.GwyDDPCurrent 
                                            WHEN  @gwyGatewayCode Like '%Reschedule%' THEN Gateway.GwyDDPNew
                                                  ELSE JobOriginDateTimePlanned END,
            Job.JobCompleted =                    CASE WHEN @gwyGatewayCode Like 'Return to%' THEN 1 
                                                  ELSE Job.JobCompleted END
        FROM JOBDL020Gateways Gateway
        INNER JOIN JOBDL000Master job ON job.Id = gateway.JobID
        WHERE gateway.ID = @currentId;
nmfujimoto commented 3 years ago

@prashantaggarwal1999 I don't believe this is working. Can you please confirm?

We are pointing m4pl-dev.meridianww.com to the Meridian_ControlTower database. Please verify the SP's are the same.

prashantaggarwal1999 commented 3 years ago

@nmfujimoto in which scenario you are able to reproduce this, we have a logic to update this while adding the Gateway already, please check the below image.

image

prashantaggarwal1999 commented 3 years ago

@nmfujimoto this is the error which we are receiving while adding the next available gateway from BizMobl "SqlDateTime overflow. Must be between 1/1/1753 12:00:00 AM and 12/31/9999 11:59:59 PM"

Please pass the date as null if this is not present as the Delivery Date is DateTime nullable.