search

merisbahti / klyva

A state management library that follows the React component model
MIT License
55 stars 4 forks source link

missing dependencies: react & react-dom #26

Closed nksfrank closed 3 years ago

nksfrank commented 3 years ago

the source code in "react-utils.ts" is importing and using both react and react-dom packages directly, but these packages are not included in the dependency field in your package.json (they are however located in devDependencies).

you could add them under peerDependencies field as ^16.8.3 to allow the end user to supply their own react/react-dom version from their project

merisbahti commented 3 years ago

Hey @nksfrank , thanks for your issue!

You suppose this would fix it? https://github.com/merisbahti/klyva/pull/27

merisbahti commented 3 years ago

I was testing this stuff around in some of my projects and it works really good, thanks for the help!