search

merit-gem / merit

Reputation engine for Rails apps
Other
1.53k stars 198 forks source link

Issue with reconfirmation of email address #328

Closed monroemann closed 5 years ago

monroemann commented 5 years ago

@tute First, thanks again for your awesome gem. It really helps us out a lot.

Second, it worked perfectly up until one week ago. It seems after we just set up email reconfirmation, but now, on production, it totally has prevented the merit gem from working, but only for new users who used the email reconfirmation. Once we comment out the email reconfirmation code, the merit gem starts working again for everyone. Here is the relevant code. I was wondering if anything jumps out at you that is causing the conflict with merit:

image image image image image

tute commented 5 years ago

I think you want to add the on: :create option to the email_confirmation validation in the User model

monroemann commented 5 years ago

@tute Hooray! Yes, that got the merit gem working again for new members. What does the on: :create code do?

However, we still have one issue: will this also allow the merit gem to work for those members who joined prior to our fixing this bug? Or do we have to manually fix those members somehow, and if so, what must we do manually to allow each of those 5 members access the merit gem too?

Thanks so much!

bhavyabh commented 5 years ago

@tute, I am working with @monroemann on this isuue. Thanks for this great gem & support.

radhika-mahtani commented 5 years ago

@tute, I am working with @monroemann on this isuue. Thanks for this great gem & support.

Following :+1:

monroemann commented 5 years ago

@bhavyabh @Shab12345 I believe we have confirmed that the fix @tute provided is also retroactive to those members for whom merit stopped working. Can one of you please confirm?

tute commented 5 years ago

Closing this issue as it's not a bug in merit, but happy to continue further discussion here.

Previously created users should be fine indeed!