merit-gem / merit

Reputation engine for Rails apps
Other
1.53k stars 198 forks source link

Typo in active_record/merit_generator task #344

Closed jlholm closed 4 years ago

jlholm commented 4 years ago

šŸ‘‹ - Just getting started with Merit (thanks for your work!)

I noticed there was a typo in the active_record/merit_generator.rb task which prevents the template from being generated, subsequently preventing the task from running successfully.

https://github.com/merit-gem/merit/blob/bde91e04387488d6d4172688a551b43e33eed28a/lib/merit/generators/active_record/merit_generator.rb#L16

I believe the template name should reference the add_merit_fields_to_model.erb template:

https://github.com/merit-gem/merit/blob/bde91e04387488d6d4172688a551b43e33eed28a/lib/merit/generators/active_record/templates/add_merit_fields_to_model.erb#L1-L6

I ran into this issue when trying to add merit_fields to one of my models.

Local error:

root@b16ac38735ed:/app# rails g merit:active_record:merit <model>
Could not find "add_merit_fields_to_model.rb" in any of your source paths. Your current source paths are:
/bundle/gems/merit-4.0.0/lib/merit/generators/active_record/templates

I can fix this is you'd like, just let me know. Thanks again!