type: :boolean for :orm

merit-gem / merit

Reputation engine for Rails apps

Other

1.53k stars 197 forks source link

type: :boolean for :orm #349

Closed burmashave closed 4 years ago

burmashave commented 4 years ago

To silence 'thor' deprecation notices.

coveralls commented 4 years ago

Coverage remained the same at 91.098% when pulling cf4d15c2ace0a4e76dc89a6bc6c51e18035c59e8 on burmashave:thor-deprecation into ea936ebc05618a85d8f521e960155cd9dcada196 on merit-gem:master.

tute commented 4 years ago

Thanks for your PR! I missed the other files in my branch (https://github.com/merit-gem/merit/issues/346#issuecomment-661242534).

It used to be a string though: it would be mongo or activerecord. But we don't support that option anymore, would you try deleting all the hooks please, and see if the warning is fixed? Thanks!

tute commented 4 years ago

Please add to the commit message th context you described well in the issue, https://github.com/merit-gem/merit/issues/346#issuecomment-661242534, so that it stays in the repository, aiding future debugging. Thank you again!

burmashave commented 4 years ago

Ah, okay. Closing this; issued a separate PR with hooks removed.