meritlabs / lightwallet-stack

Other
3 stars 1 forks source link

Fee must be deducted properly in case of easySend. #473

Open adilwali opened 6 years ago

adilwali commented 6 years ago

Today, the user expects, for example, to send 1MRT to a friend via EasySend. Even if they select "I pay the fee", the recipient will get something like .999938 MRT.

This is because EasySend fees must be calculated differently than typical sends, because of the intermediary escrow. This needs to be taken into account and presented to the user.

favetisov commented 6 years ago

Fixed in https://github.com/meritlabs/lightwallet-stack/pull/478

adilwali commented 6 years ago

I retested this yesterday on v0.2.3 (iOS), and got an inconsistent result.

Let's screenshare and walk through a couple flows on this.