search

meritlabs / merit

Merit aims to be the world's most adopted digital currency.
https://www.merit.me
MIT License
192 stars 20 forks source link

Leaderboard does not show all wallets #404

Open disifi opened 6 years ago

disifi commented 6 years ago

Describe the issue

Leaderboard shows only one wallet on each place. If more wallets have same score, only one of them can be found in leaderboard.

Can you reliably reproduce the issue?

On block 436122 like this:

  1. find zero balance wallet e.g. MRBNdavWcoRsE6DP9VzSA4qrtfNs25sEP8
  2. check rank of the wallet with getaddressrank '{"addresses": ["MRBNdavWcoRsE6DP9VzSA4qrtfNs25sEP8"]}' (13184 now on this block)
  3. run getaddressleaderboard 20000 to show whole leaderboard
  4. check 13184th place, there is another wallet (MNPd1JPUdEeykEWaygboKjiyRg1fJ58Zr8 now)

Expected behaviour

I would expect to find my wallet in leaderboard.

Actual behaviour

My wallet is eventually not found in leaderboard if it's on the same place as some other wallet.

What version of merit-core are you using?

0.7.0

adilwali commented 5 years ago

@disifi Thanks for reporting this. I'm sorry for the delay in addressing the issue. We have plans to improve the leaderboard functionality, but it's not part of our near-term roadmap.

I'll keep you posted here.