search

merixstudio / django-trench

django-trench provides a set of REST API endpoints to supplement django-rest-framework with multi-factor authentication (MFA, 2FA). It supports both standard built-in authentication methods, as well as JWT (JSON Web Token).
Other
274 stars 57 forks source link

#169 | Fix deactivation of MFA Method #186

Closed wmaciejewskimer closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #186 (6f61540) into develop (656a1f7) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #186      +/-   ##
===========================================
+ Coverage    97.01%   97.03%   +0.01%     
===========================================
  Files           33       34       +1     
  Lines          637      641       +4     
===========================================
+ Hits           618      622       +4     
  Misses          19       19
Impacted Files Coverage Δ
trench/command/deactivate_mfa_method.py 100.00% <ø> (ø)
...od_id_mfamethod_unique_user_is_primary_and_more.py 100.00% <100.00%> (ø)
andruten commented 1 year ago

I've tested this branch with the steps I mentioned in #169 and I can confirm this is solving the issue. LGTM. Thanks!