merkatsu / website

3 stars 0 forks source link

Sidebar pushes the page to the left #55

Closed mariacovasgrilo closed 9 years ago

mariacovasgrilo commented 9 years ago

When you open the sidebar, the whole page is pushed to the left.

Instead, it should open over the content ("above" it). Illustrated underneath:

shop

esperancaJS commented 9 years ago

As we had talked before like this it allowes the user editing to fully see the page. Why should it be like this?

mariacovasgrilo commented 9 years ago

It's true we talked about this before, I seem to have forgotten. But independently of being previously discussed or not, I now felt that this creates some problems with, for example, previewing the look that the page would have. The proportions look completely different. And the stuff on the right side, come to think about it, are not that relevant. For now, I think the best solution for this change of proportions right now would be to just overlay the sidebar, of course not excluding the possibility of creating a different, better solution in the future.

esperancaJS commented 9 years ago

some points towards a side page without overlay:

mariacovasgrilo commented 9 years ago

Ok, very good point. I will then have to work on the flexibility of the page, because the way it is right now, is not working.

What I was saying is that meanwhile, whilst I don't have a solution - because maybe it's not the biggest priority - we should just overlay it, with the conscience that it isn't at all a permanent solution.

esperancaJS commented 9 years ago

If after alpha we still feel like it's not working I'll implement a new solution. But this should be strongly avoided in my opinion because it's a costly temporary fix that also stears the UX in a different direction

djtanuzzo commented 9 years ago

This was labeled as ready yet the sidebar still pushes the content of the page out of screen.

esperancaJS commented 9 years ago

yes, because this is a discussion. And with the new updates I think it is now more clear that this solution is the best

djtanuzzo commented 9 years ago

I think this is actually an issue only sometimes, and not always. For some reason sometimes the system clips the content out of screens, and other times it does not. Pics to demonstrate.

mrkts11 mrkts12

esperancaJS commented 9 years ago

yep, that's clearly a bug.

skeptic webdevelopment 101: everything done will produce some unexpected behaviors that need atention

for this reason I think we should stick with this kind of side page behaviour and work towards making it work.