search

merken / Prise

A .NET Plugin Framework.
https://merken.github.io/Prise
MIT License
362 stars 39 forks source link

Dispose errors fix #50

Closed jonilviv closed 2 years ago

jonilviv commented 3 years ago
  1. Renaming files to class names and move some classes and interfaces to they own files.
  2. Fixed issue with wrong IDisposable implementation. We no need to call GC.SuppressFinalize in Dispose method if we not implement finalizer logic.
  3. We should check all objects for null (or use ?) inside Dispose.
  4. We need to stop disposing if another disposing was already started in other thread or loop.
merken commented 3 years ago

Hi @jonilviv

Thanks for contributing. Please fix the review comments in order to fix the build