search

merland / seedpicker

Create your own BIP39 seed phrase, securely and transparently.
http://seedpicker.net
MIT License
44 stars 20 forks source link

Add QR Code Output #34

Closed mflaxman closed 2 years ago

mflaxman commented 3 years ago

Will want to do this in a way that's compatible with Specter-Desktop.

From @stepansnigirev here:

Regarding QR codes - the same as for text - [xfp/derivation]xpub should work fine. Also, all json-like formats that Cobo Vault uses, but I am more a fan of simple plaintext for that. If you want to encode more than one xpub in the QR code you can separate it with \n and Specter will understand that.

merland commented 3 years ago

Planning to reinstate the QR code any day now! :) The bulk of the code from the previous QR implementation can be reused. Stay tuned! Good to have a Github issue for it.

merland commented 3 years ago

Implemented and tested against Specter, both mainnet and testnet. Works, but I'd like to make the modal look nicer, and maybe add some info and/or reminder to double check the info.

mflaxman commented 3 years ago

Can you make it much bigger? Every camera/scanner is different, but typically you want to use as much of the screen real estate as is available. Screen Shot 2020-09-30 at 1 26 33 PM

merland commented 3 years ago

Sure! It worked flawlessly for me, even though I tested via my phone screen. But I guess you are right about the real estate :)

merland commented 3 years ago

Made it bigger and added a reminder about verifying the scan/transfer. Suggestions for copy changes/additions?

mflaxman commented 3 years ago

This is an improvement, but still kind of small (extreme case on big display here): Screen Shot 2020-10-01 at 2 08 03 PM

How about set modal-content, .modal-card width to 90% and get rid of the three-fifths / two-fifths column classes (switch to a vertical layout)?

Maybe as-is will work (I didn't test), but I've seen this be a problem in soooo many QR setups and it can really frustrate users. Big QRs with % sizes (not fixed pixels) let them try growing/shrinking the QR very easily.

merland commented 3 years ago

Wow, that's a huge screen :D I get why you think the modal is small. On my macbook the modal takes up roughly half the screen! I agree that it would be nice to have resizable QRs but I think I will work on other tasks a bit before I come back to improve on this one. PRs welcome though :)

Do many people use huge screens like that? Personally, I mostly use only the laptop screen, and I somewhat fear getting used to a big monitor. Would keep me from working from anywhere!

merland commented 3 years ago

Btw, since the QR conveys sensitive information in this case, bigger isn't only better. If someone takes a picture on your screen from far away, a small enough QR is a security feature!

mflaxman commented 3 years ago

Do many people use huge screens like that? Personally, I mostly use only the laptop screen, and I somewhat fear getting used to a big monitor. Would keep me from working from anywhere!

Monitors are getting really cheap so it's popular. But ya, it does make travel annoying. Sometimes I'll just buy a medium-sized monitor in a city and then leave it behind.

Btw, since the QR conveys sensitive information in this case, bigger isn't only better. If someone takes a picture on your screen from far away, a small enough QR is a security feature!

I don't think this is much of a concern, you should be doing seed generation in a secure location anyway. If someone can look over your shoulder you're already doing it wrong, especially since it's a slow process and you're going to want to double-check the results.