search

merland / seedpicker

Create your own BIP39 seed phrase, securely and transparently.
http://seedpicker.net
MIT License
44 stars 20 forks source link

Seedpicker loses 3 bits of entropy #46

Closed jambolo closed 2 years ago

jambolo commented 2 years ago

The 24th word contains 3 bits of entropy and 8 bits of checksum. When computing the 24th word, those 3 bits of entropy are always set to 0. They should be set randomly for maximum security.

jambolo commented 2 years ago

Already addressed.

merland commented 2 years ago

Thanks for commenting. For future reference, this topic was discussed in issues #39 and #45.