search

merliseclyde / BAS

BAS R package https://merliseclyde.github.io/BAS/
https://merliseclyde.github.io/BAS/
GNU General Public License v3.0
41 stars 16 forks source link

valgrind identifies uninitialized variables in `glm_fit.c` #72

Closed merliseclyde closed 7 months ago

merliseclyde commented 7 months ago

Describe the bug

` ==1933038== Conditional jump or move depends on uninitialised value(s)

==1933038== at 0x11D96FC1: glm_bas (packages/tests-vg/BAS/src/glm_fit.c:147)

`

To Reproduce run under docker see (https://github.com/merliseclyde/docker-valgrind](https://github.com/merliseclyde/docker-valgrind) )

RDvalgrind  CMD build BAS
ulimit 4096
RDvalgrind CMD check --use-valgrind BAS_1.6.6.9000.tar.gz
RDvalgrind  CMD INSTALL --dsym  BAS_1.6.6.9000.tar.gz
RDvalgrind -d "valgrind --tool=memcheck --leak-check=full --track-origins=yes  --log-fd=1 --log-file=BAS.Rcheck/BAS-valgrind.txt" --vanilla < BAS.Rcheck/BAS-Ex.R

Desktop (please complete the following information):

Additional context See https://www.stats.ox.ac.uk/pub/bdr/memtests/valgrind/BAS/

merliseclyde commented 7 months ago

passes checks on r-devel with valgrind using Docker