search

merll / docker-fabric

Integration of Docker deployments into Fabric.
MIT License
79 stars 10 forks source link

Regex for CLI parser is too narrow #11

Closed merll closed 7 years ago

merll commented 7 years ago

This has been reported in #8, and is created as a new issue for tracking when it is fixed:

Removing the docker.Client check in #10 (and not adding it to the CLI class) has resolved the -H issue. The next issue I ran into was the CREATED_AT_PATTERN regex. Specifically, my time component was:

2016-12-06 18:09:58 -0500 EST

The regex pattern doesn't like the - timezone and can be fixed as:

CREATED_AT_PATTERN = re.compile(r'(\d{4})-(\d{2})-(\d{2}) (\d{2}):(\d{2}):(\d{2}) .\d{4} \w+')

I tried (+|-) but it creates an additional, invalid group. The . will match anything but this isn't too risky since the rest of the pattern has to work.

merll commented 7 years ago

Fixed in Docker-Map release 0.7.1.