Closed dependabot[bot] closed 1 year ago
Can you bring it with the Mermaid project? If they do not respond within a couple of days, we will update the mermaid version in mermaid-cli and make a release. I do not think it is a blocker. In general, we do not want to fall behind with mermaid versions. Another thing, can we suggest the mermaid project to use Percy for their quality assurance? 😄 It is not the first time we catch a regression in the parent project 🧜♀️
Can you bring it with the Mermaid project?
Reported as https://github.com/mermaid-js/mermaid/issues/4455, I even found the commit that changed the behavior!
I do not think it is a blocker.
Yep, neither do I! I'm going to merge this PR now, although I suspect @dependabot will soon make a PR for Mermaid v10.2.2, since that has just come out. Would you be happy to make a release and publish everything to NPM>?
Another thing, can we suggest the mermaid project to use Percy for their quality assurance?
I think the problem is that they have too many images/changes to fall into the free tier of any SaaS visual regression product. They do use https://applitools.com/, but due to the small amount of API credits, they generally only do it right before release.
There's a PR to add some open-source visual regression testing using GitHub Actions (see https://github.com/mermaid-js/mermaid/pull/3894), but IMO, it currently has a bunch of issues that makes it unlikely to be merged as it is.
Superb work!!! 😄
Bumps mermaid from 10.1.0 to 10.2.0.
Release notes
Sourced from mermaid's releases.
... (truncated)
Commits
8d43b87
Mermaid version 10.2.09c12c42
Mermaid Version 10.2.0-rc.45bfe325
Label background fixbd616e0
Test commit9fb2531
Fix for regression error in sequenceDiagrams78efac2
Fix visibility issue for fields58ec268
Merge branch 'release/10.2.0' of https://github.com/mermaid-js/mermaid into r...3a5c4a1
fix parsing issue with class diagrams132ce2f
Merge branch 'develop' into release/10.2.0458ac84
Merge pull request #4383 from amsubhash/feature/4282_add_quadrant_chartDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)