Closed aloisklink closed 1 year ago
Thank you! :)
Please, resolve the merge conflicts and let's merge it 😄
I've rebased on to master
to solve the merge conflicts!
Hmmmm, the generated ZenUML png
have a lot of whitespace on the right of the image, see
Do you think this is okay to merge? My gut feeling is yes, since having an image is better than having no image, and users can always use something like imagemaick's -trim
to auto-crop the image.
:bookmark_tabs: Summary
Mermaid now has support for ZenUML diagrams, but it requires using a Mermaid plugin diagram, see https://mermaid.js.org/syntax/zenuml.html
ZenUML adds about 700 KiB to our
dist/index.html
file, or about 200 KiB when gzipped.Resolves #564
:straight_ruler: Design Decisions
Adding support for ZenUML diagrams is just like how we previously added support for mindmap diagrams in PR https://github.com/mermaid-js/mermaid-cli/pull/424, so please see discussion in that PR for design decisions.
By the way, I had to manually limit the version of
antlr4
to~4.11.0
, since v4.12.0 (in commit https://github.com/antlr/antlr4/commit/2c75e642796718273fd215b03a310d4958319bad) drops NodeJS v14 support.New size of mermaid-cli package:
ZenUML adds about 700 KiB to our
dist/index.html
file, or about 200 KiB when gzipped. Additionally, it takes about 2.5 seconds longer to build thedist/index.html
file, about a 25% increase.Currently
After adding
@mermaid-js/mermaid-zenuml
:clipboard: Tasks
Make sure you
test-positive/zenuml.mmd
master
branch