perf: skip launching puppeteer when not needed - Githubissues

mermaid-js / mermaid-cli

Command line tool for the Mermaid library

MIT License

2.52k stars 238 forks source link

perf: skip launching puppeteer when not needed #696

Closed aloisklink closed 5 months ago

aloisklink commented 5 months ago

:bookmark_tabs: Summary

Skip launching puppeteer until it's actually needed.

Running mermaid-cli on a markdown file without any mermaid code blocks shouldn't launch puppeteer, if it's unnecessary.

Resolves https://github.com/mermaid-js/mermaid-cli/issues/694

:straight_ruler: Design Decisions

N/A

:clipboard: Tasks

Make sure you

[x] :book: have read the contribution guidelines
[x] :computer: have added unit/e2e tests (if appropriate)
[x] :bookmark: targeted master branch

MindaugasLaganeckas commented 5 months ago

Thank you!