mermaid-js / mermaid-live-editor

Edit, preview and share mermaid charts/diagrams. New implementation of the live editor.
https://mermaid.live
MIT License
3.82k stars 574 forks source link

fix: stop returning when err so diagram can be rendered post error fix #1449

Open ad1992 opened 1 month ago

ad1992 commented 1 month ago

:bookmark_tabs: Summary

Currently in production if for any reason an error occurs, the diagram gets stuck and isn't rendered even after error is fixed hence I have fixed that in this PR

eg, try with below code and config in prod vs this PR

flowchart TD
    A[Christmas] -->|Get money| B(Go shopping)
    B --> C{Let me think}
    C -->|One| D[Laptop]
    C -->|Two| E[iPhone]
    C -->|Three| F[fa:fa-car Car]
  {
  "theme": "default",
  "maxEdges": "10"

change the config to 2 and change it back to 10 -> In prod the diagrams will not rerender until refresh.

netlify[bot] commented 1 month ago

Deploy Preview for mermaidjs ready!

Name Link
Latest commit 81d34c8e7f1d7cb08f4342fd2d3e5d1bfc0f21d8
Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/664310b59efd0f00083c8dec
Deploy Preview https://deploy-preview-1449--mermaidjs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ad1992 commented 1 month ago

cc @sidharthv96

ad1992 commented 1 month ago

friendly reminder @sidharthv96