mermaid-js / mermaid-live-editor

Edit, preview and share mermaid charts/diagrams. New implementation of the live editor.
https://mermaid.live
MIT License
4.3k stars 654 forks source link

Preventing requests to the AnalyticsURL if it is not set #1531

Open emahiro opened 2 months ago

emahiro commented 2 months ago

:bookmark_tabs: Summary

I noticed that my self-hosted Mermaid Live Editor is sending requests to the analytics URL when I didn't set the analytics URL and the mermaid domain, and I believe it should be configured according to the instructions provided in the https://github.com/mermaid-js/mermaid-live-editor?tab=readme-ov-file#to-configure-analytics.

My expectation is that the Mermaid Live Editor should not be sending requests to the analytics URL because, according to the README, the default setting is empty, which disables analytics.

Therefore, I would like to make changes to address this issue.

Brief description about the content of your PR:

Resolves #

:straight_ruler: Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

:clipboard: Tasks

Make sure you

netlify[bot] commented 2 months ago

Deploy Preview for mermaidjs ready!

Name Link
Latest commit 976f23952da4b2d9305ce88ce66ecc8bcfeaf61d
Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/66eefd45868a650008ea49f2
Deploy Preview https://deploy-preview-1531--mermaidjs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.