Open lschierer opened 1 year ago
I think using markdown formatting
instead of html formatting
would better.
I don't know how to grab the text before it gets translated by astro if I use mermaid from within an mdx component, and if I use mermaid as a markdown or mdx integration (and have the markdown parser call it), then the graph is in a code block and the foot notes won't get rendered into HTML at all.
I'm taking a look at this - it looks like the drawing in some other diagrams, e.g. mindmaps, already account for text nodes with markdown, so I'll try use the same patterns for timelines.
I have a change for this to make timelines behave the same as mind maps (which accept markdown) - a pull request will follow in the next week, I’m just wrestling with end to end tests at the mo.
awesome, thanks
@lschierer, So this issue will be resolved once the feature of markdown by @jonnymoo is merged and implemented into the main code? Please correct me if I am wrong.
I haven't tried to build my own package to test his PR, but yes I believe so.
Description
Currently html is allowed in labels for Flow Charts and for Class diagrams, but not for other diagram types. While I have not tested all of them, I have tested with timeline and tags that work in the Flow Chart type do not work in the Timeline type. The timeline labels are a natural spot where I can have a paragraph of text that may desire formatting to include
<em> and <strong>
tags (for emphasis),<sup> and <a href... >
tags (for footnotes), and possibly<ul> and <li>
tags.Right now it attempts to render these as plain text. Sometimes this works, other times, such as the the href case with its quotes in the string, it results in a cut off label.
Steps to reproduce
paste the following diagram into the live editor:
Screenshots
No response
Code Sample
link to Live Editor (which happens to render as the graph in question):
Setup
Suggested Solutions
The implementation in the Flow Chart graph type seems to work.
Additional Context
No response